Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean-ups #294

Merged
merged 1 commit into from
Aug 21, 2019
Merged

chore: clean-ups #294

merged 1 commit into from
Aug 21, 2019

Conversation

remusao
Copy link
Collaborator

@remusao remusao commented Aug 21, 2019

  • Remove use of eslint completely (all source code is TypeScript so tslint is enough)
  • Remove Dockerfile, run_tests.sh, .dockerignore
  • Move bench to TypeScript
  • Remove un-used bench/dataset/ folder
  • Make sure that all sub-packages can be installed and built independently (fix missing deps)

@remusao remusao changed the title clean-ups chore: clean-ups Aug 21, 2019
remusao added a commit to remusao/adblocker that referenced this pull request Aug 21, 2019
* Remove use of `eslint` completely (all source code is TypeScript so `tslint` is enough)
* Remove `Dockerfile`, `run_tests.sh`
* Move `bench` to TypeScript
* Remove un-used `bench/dataset/` folder
* Make sure that all sub-packages can be installed and built independently (fix missing deps)
remusao added a commit to remusao/adblocker that referenced this pull request Aug 21, 2019
* Remove use of `eslint` completely (all source code is TypeScript so `tslint` is enough)
* Remove `Dockerfile`, `run_tests.sh`
* Move `bench` to TypeScript
* Remove un-used `bench/dataset/` folder
* Make sure that all sub-packages can be installed and built independently (fix missing deps)
* Remove use of `eslint` completely (all source code is TypeScript so `tslint` is enough)
* Remove `Dockerfile`, `run_tests.sh`
* Move `bench` to TypeScript
* Remove un-used `bench/dataset/` folder
* Make sure that all sub-packages can be installed and built independently (fix missing deps)
@remusao remusao merged commit 9b084ac into ghostery:master Aug 21, 2019
@remusao remusao mentioned this pull request Aug 27, 2019
@remusao remusao deleted the clean-up branch September 5, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Internal 🏠 Changes only affect internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant